Gradle maven fallback streaming optymization#125
Conversation
|
This branch currently has no diff against #114 ( On the change itself: I flagged the buffering divergence in #114 as a behavioural note rather than a performance problem. The marker fallback path only handles plugin marker POMs (<1KB), checksum sidecars (~40 bytes) and If you do still want to pursue it, please either retarget the base branch to |
0337ca3 to
4aa7863
Compare
|
Thanks for pushing the actual change, had another look now #114 is merged. The title/description frame this as a streaming optimisation but most of the diff is a behaviour change: the plugin-portal fallback is now gated to Gradle plugin marker coordinates only (artifact ends in The gating introduces a regression. I like the idea of skipping the second round-trip for ordinary Central misses, but I can't see a way to identify implementation artifacts from the path alone, so the gate as written breaks portal-only plugins. A few smaller things:
Up to you whether to close this or rework it. If you want to keep going, I'd suggest retitling/redescribing around the fallback gating (since that's the real change), reinstating the implementation-metadata test, and figuring out what to do about portal-only implementation checksums. Happy to discuss approaches on that last point. |
Follow-up to #114
This performance fix ensures fallback metadata requests are streamed when metadata caching is disabled, removing the buffering bottleneck on that path. It applies when the primary upstream returns 404 for Gradle plugin marker metadata requests.